mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 70412: Made the operation feedback example framwork cleanup old reservations.
Date Mon, 08 Apr 2019 23:56:44 GMT


> On April 8, 2019, 5:26 p.m., Benno Evers wrote:
> > src/examples/operation_feedback_framework.cpp
> > Lines 329 (patched)
> > <https://reviews.apache.org/r/70412/diff/1/?file=2137761#file2137761line333>
> >
> >     Is this always true even in the presence of `RESERVATION_REFINEMENT`?
> 
> Gastón Kleiman wrote:
>     This framework only pushes one reservation, so I guess that there should only be
one element for reservations made by it?
>     
>     The check would fail if the example framework shares a role with another framework
that is using reservation refinement. Is that a case that we want to contemplate for a simple
example framework?
>     
>     If so, the framework should probably check the labels of all the reservations.

Yea we would only hit a failure at this CHECK if another framework refined the reservations
made by this framework. I'm fine with making the assumption that that will not occur, what
do you guys think?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70412/#review214468
-----------------------------------------------------------


On April 5, 2019, 11:35 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70412/
> -----------------------------------------------------------
> 
> (Updated April 5, 2019, 11:35 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a flag to the operation feedback example framework that
> makes it unreserve resources that were reserved by another instance of
> the framework.
> 
> NOTE: The new flag should only be enabled if the example framework is
> the only framework making reservations for a given role. Otherwise it
> will unreserve reservations made by another framework.
> 
> 
> Diffs
> -----
> 
>   src/examples/operation_feedback_framework.cpp 2480c340c4ccb4246098c35e0315093f3eb44e81

> 
> 
> Diff: https://reviews.apache.org/r/70412/diff/1/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message