mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70418: Added a test to verify the sort correctness of the random sorter.
Date Mon, 08 Apr 2019 19:32:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70418/#review214473
-----------------------------------------------------------


Fix it, then Ship it!




Do we want to test the hierarchical weighting as well in this test? Or separately? Gave a
ship it assuming a separate test.


src/tests/sorter_tests.cpp
Lines 99 (patched)
<https://reviews.apache.org/r/70418/#comment300678>

    It doesn't look like the SET UP and TEST comments are helpful in this test to me, rather
it seems more helpful to have a small paragraph at the top, much like the test that this copies?
    
    ```
    // Test the behavior of the random sorter by ensuring that the
    // probability distribution after a number of runs is within
    // a particular error bound.
    ```



src/tests/sorter_tests.cpp
Lines 120 (patched)
<https://reviews.apache.org/r/70418/#comment300677>

    Where is toVector declared and why do you need to call it here when sort return std::vector
already?


- Benjamin Mahler


On April 8, 2019, 3:04 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70418/
> -----------------------------------------------------------
> 
> (Updated April 8, 2019, 3:04 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to verify the sort correctness of the random sorter.
> 
> 
> Diffs
> -----
> 
>   src/tests/sorter_tests.cpp 9d52a80eafb6f955386a6575875daacf5d4b4e9e 
> 
> 
> Diff: https://reviews.apache.org/r/70418/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message