mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70402: Implemented CSI v1 volume manager.
Date Mon, 08 Apr 2019 16:30:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70402/#review214463
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/csi/v1_volume_manager.cpp
Lines 37 (patched)
<https://reviews.apache.org/r/70402/#comment300668>

    Did you intend to include `stout/os/mkdir.hpp` instead?


- Benjamin Bannier


On April 5, 2019, 8:30 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70402/
> -----------------------------------------------------------
> 
> (Updated April 5, 2019, 8:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Bugs: MESOS-9623
>     https://issues.apache.org/jira/browse/MESOS-9623
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The v1 Volume manager is basically copied from the v0 volume manager,
> with the following changes:
> 
>   * `validateVolume` will validate volumes against parameters.
> 
>   * `publishVolume` will only create the parent directory of the target
>     path. The creation of the target path itself is the responsibility
>     of the plugin.
> 
>   * The node ID is obtained through the `NodeGetInfo` call.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt af3715a060b677da86d6d9a56b360f17be2bd0d3 
>   src/Makefile.am a80044448563b3507d08a81857097ba4a39210fe 
>   src/csi/v1_volume_manager.hpp PRE-CREATION 
>   src/csi/v1_volume_manager.cpp PRE-CREATION 
>   src/csi/v1_volume_manager_process.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70402/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> The codepath is not activated yet. More testing will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message