mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70419: Refactor `Sorter::sorted()` to return `class SortedCandidates`.
Date Mon, 08 Apr 2019 07:10:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70419/#review214453
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70418', '70419']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3114/mesos-review-70419

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3114/mesos-review-70419/logs/mesos-tests.log):

```
I0408 07:09:57.317137 39332 master.cpp:1295] Agent d1946c76-653d-4c04-8c74-ce473236a572-S0
at slave(500)@192.10.1.4:64081 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
disconnected
I0408 07:09:57.317137 39332 master.cpp:3333] Disconnecting agent d1946c76-653d-4c04-8c74-ce473236a572-S0
at slave(500)@192.10.1.4:64081 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0408 07:09:57.317137 40788 hierarchical.cpp:394] Removed framework d1946c76-653d-4c04-8c74-ce473236a572-0000
I0408 07:09:57.317137 39332 master.cpp:3352] Deactivating agent d1946c76-653d-4c04-8c74-ce473236a572-S0
at slave(500)@192.10.1.4:64081 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0408 07:09:57.318128 33756 hierarchical.cpp:831] Agent d1946c76-653d-4c04-8c74-ce473236a572-S0
deactivated
I0408 07:09:57.318128 36984 containerizer.cpp:2576] Destroying container 73f2a489-7bc1-4734-926c-d6fb83e4ffb2
in RUNNING state
I0408 07:09:57.319130 36984 containerizer.cpp:3278] Transitioning the state of container 73f2a489-7bc1-4734-926c-d6fb83e4ffb2
from RUNNING to DESTROYING
I0408 07:09:57.319130 36984 launcher.cpp:161] Asked to destroy container 73f2a489-7bc1-4734-926c-d6fb83e4ffb2
W0408 07:09:57.321122 33548 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=5788
to peer '192.10.1.4:50148': IO failed with error code: The specified network name is no longer
available.

W0408 07:09:57.322126 33548 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=5672
to peer '192.10.1.4:50149': IO failed with error code: The specified network name is no longer
available.

I0408 07:09:57.372179 40788 containerizer.cpp:3117] Container 73f2a489-7bc1-4734-926c-d6fb83e4ffb2
has exited
I0408 07:09:57.409132 35736 ma[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
(879 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (898 ms total)

[----------] Global test environment tear-down
[==========] 1158 tests from 108 test cases ran. (594110 ms total)
[  PASSED  ] 1156 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

ster.cpp:1135] Master terminating
I0408 07:09:57.411124 40788 hierarchical.cpp:682] Removed agent d1946c76-653d-4c04-8c74-ce473236a572-S0
I0408 07:09:58.085131 33548 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 8, 2019, 3:06 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70419/
> -----------------------------------------------------------
> 
> (Updated April 8, 2019, 3:06 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch refactors `Sorter::sorted` to return an abstract
> class `SortedCandidates` instead of a whole `vector<string>`.
> Callers can then use `SortedCandidates::next()` to get the
> next sorted candidate. This paves the way for sort optimization
> where sorting of the whole clients can be lazily done as callers
> ask for the next client.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 64a076ddd29711437d539a06bb0470755828cc87

>   src/master/allocator/sorter/drf/sorter.hpp 91a9d668b87079158f7072780dc86bb08865166e

>   src/master/allocator/sorter/drf/sorter.cpp 554ac84ee585d1d07048a58cf7d7d1e6586252ee

>   src/master/allocator/sorter/random/sorter.hpp 125ce84761e4c930370912151700ddda35d7b6c1

>   src/master/allocator/sorter/random/sorter.cpp bbe130dbf3b158ea14f9572bc5d14200fcd85127

>   src/master/allocator/sorter/sorter.hpp d56a1166a9e82b034564842ac071874ec2885004 
>   src/tests/sorter_tests.cpp 9d52a80eafb6f955386a6575875daacf5d4b4e9e 
> 
> 
> Diff: https://reviews.apache.org/r/70419/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message