mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70395: Enhanced HierarchicalAllocatorTest.QuotaWithNestedRoleReservation.
Date Fri, 05 Apr 2019 17:32:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70395/#review214425
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/hierarchical_allocator_tests.cpp
Line 6130 (original), 6130 (patched)
<https://reviews.apache.org/r/70395/#comment300626>

    I think this should be:
    
    Add a second agent with cpus:10;mem:1000


- Meng Zhu


On April 4, 2019, 7:47 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70395/
> -----------------------------------------------------------
> 
> (Updated April 4, 2019, 7:47 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9688 and MESOS-9691
>     https://issues.apache.org/jira/browse/MESOS-9688
>     https://issues.apache.org/jira/browse/MESOS-9691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test missed an issue in https://reviews.apache.org/r/70393/
> because it was only checking that the quota consumption for "a"
> was >= the subrole "a/b" reservation. Updated this test to ensure
> that the quota consumption is exactly equal to the subrole "a/b"
> reservation.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp c7edee2f49bfac0796c9506265d3bb766416ee63

> 
> 
> Diff: https://reviews.apache.org/r/70395/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message