mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70405: Fixed use-after-free bug in Docker provisioner store.
Date Fri, 05 Apr 2019 13:51:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70405/#review214418
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70287, 70354, 70365, 70288, 70289, 70290, 70291, 70366, 70405]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On April 5, 2019, 1:53 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70405/
> -----------------------------------------------------------
> 
> (Updated April 5, 2019, 1:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gilbert Song, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Deferred lambda callback of the `moveLayers()` to the `StoreProcess`
> to prevent use-after-free of the process object since the callback
> refers to the `StoreProcess` class variable `flags`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 909364d21318956ed5e4c53419479d6d38d83858

> 
> 
> Diff: https://reviews.apache.org/r/70405/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message