mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Fri, 05 Apr 2019 11:53:16 GMT


> On April 5, 2019, 7:11 a.m., Benjamin Bannier wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp
> > Line 433 (original), 449-467 (patched)
> > <https://reviews.apache.org/r/70288/diff/7/?file=2137385#file2137385line449>
> >
> >     This lambda captures this but does not defer to the process so we can run into
use-after-free bugs here.
> >     ```
> >     /tmp/SRC/src/slave/containerizer/mesos/provisioner/docker/store.cpp:449:11:
warning: callback capturing this should be dispatched/deferred to a specific PID [mesos-this-capture]
> >        .then([=]() -> Future<Image> {
> >              ^
> >     ```
> >     
> >     This needs to either be defered to `StoreProvcess`, or we need to copy `flags.docker_store_dir`
in manually.

Addressed in a separate patch https://reviews.apache.org/r/70405/


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review214405
-----------------------------------------------------------


On April 4, 2019, 8 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated April 4, 2019, 8 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/uri/fetchers/docker.cpp a87d7f086378539e6c8048e935389919a1164fbc 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message