mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70402: Implemented CSI v1 volume manager.
Date Fri, 05 Apr 2019 06:30:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70402/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jan Schlicht.


Bugs: MESOS-9623
    https://issues.apache.org/jira/browse/MESOS-9623


Repository: mesos


Description
-------

The v1 Volume manager is basically copied from the v0 volume manager,
with the following changes:

  * `validateVolume` will validate volumes against parameters.

  * `publishVolume` will only create the parent directory of the target
    path. The creation of the target path itself is the responsibility
    of the plugin.

  * The node ID is obtained through the `NodeGetInfo` call.


Diffs
-----

  src/CMakeLists.txt af3715a060b677da86d6d9a56b360f17be2bd0d3 
  src/Makefile.am a80044448563b3507d08a81857097ba4a39210fe 
  src/csi/v1_volume_manager.hpp PRE-CREATION 
  src/csi/v1_volume_manager.cpp PRE-CREATION 
  src/csi/v1_volume_manager_process.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70402/diff/1/


Testing
-------

make check

The codepath is not activated yet. More testing will be done later in the chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message