mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 70401: Updated CSI volume state fields to match names in v1 spec.
Date Fri, 05 Apr 2019 06:29:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70401/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jan Schlicht.


Bugs: MESOS-9623
    https://issues.apache.org/jira/browse/MESOS-9623


Repository: mesos


Description
-------

We rename `volume_attributes` to `volume_context` and `publish_info` to
`publish_context` in `state.proto` to match the new CSI v1 standard to
avoid confusions. Since this protobuf message is only used for
checkpointing and the binary format does not change, there will be no
compatibility issue.


Diffs
-----

  src/csi/state.proto b7213ed0f344eea30bdd97bcf40719b19778c1fb 
  src/csi/v0_volume_manager.cpp 7de900095bb86c207869c599c17ca08838e722be 
  src/csi/v0_volume_manager_process.hpp 88073e423559f1fc5d171dbbac26e46472589e5a 


Diff: https://reviews.apache.org/r/70401/diff/1/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message