mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70362: Added the `mesos::csi::v1::Client` wrapper.
Date Fri, 05 Apr 2019 06:06:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70362/
-----------------------------------------------------------

(Updated April 5, 2019, 6:06 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Added comparison summary between v0 and v1 wrappers in the description.


Bugs: MESOS-9623
    https://issues.apache.org/jira/browse/MESOS-9623


Repository: mesos


Description (updated)
-------

The differences between CSI v0 and v1 client wrappers are summarized as
follows:

  * Added snapshot related functions: `createSnapshot`,
    `deleteSnapshot` and `listSnapshots`.

  * Added volume expansion related functions: `controllerExpandVolume`
    and `nodeExpandVolume`.

  * Added volume statistics related functions: `nodeGetVolumeStats`.

  * Replaced `nodeGetId` with `nodeGetInfo`.


Diffs
-----

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3 
  src/csi/v1_client.hpp PRE-CREATION 
  src/csi/v1_client.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/70362/diff/2/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message