mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70360: Bundled CSI spec 1.1.0.
Date Fri, 05 Apr 2019 06:00:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70360/
-----------------------------------------------------------

(Updated April 5, 2019, 6 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Added some details about `PROTOBUF_PROTOCFLAGS` to the description.


Bugs: MESOS-9624
    https://issues.apache.org/jira/browse/MESOS-9624


Repository: mesos


Description (updated)
-------

Since the CSI v1 spec proto file depends on certain proto files in the
Protobuf library, we have to ensure the Protobuf library's include path
is in the proto paths of the `protoc` command when compiling the CSI
spec proto file. Specifically in Autotools, this path is passed through
the `PROTOBUF_PROTOCFLAGS` variable when building with an unbundled
protobuf library.


Diffs
-----

  3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
  3rdparty/Makefile.am 98a2623b34132885279bea6135c0da4ffc8c59cf 
  3rdparty/cmake/Versions.cmake 972c706a18bfce45af6c2632b326606052888b02 
  3rdparty/csi-1.1.0.tar.gz PRE-CREATION 
  3rdparty/versions.am 24381073f4c77d92c5ba62f54bb2194bf041ee6c 
  configure.ac 5302e666a524de37713f8caae33e5671531dc8a9 
  src/CMakeLists.txt f1c3114f809ed775e09252ec1f811f8504cbde17 
  src/Makefile.am ea8e1760ffe7fd30d47176a37a5eabf6618bb365 
  src/cmake/MesosProtobuf.cmake 09074d77a1df5076c6e51292523ce994a77a88f2 


Diff: https://reviews.apache.org/r/70360/diff/3/


Testing
-------

make distcheck


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message