mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70382: Avoid looping over role allocations during headroom computation.
Date Fri, 05 Apr 2019 04:27:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70382/#review214400
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70391, 70392, 70393, 70370, 70373, 70374, 70382]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2019, 12:03 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70382/
> -----------------------------------------------------------
> 
> (Updated April 4, 2019, 12:03 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that the sorter exposes the allocation information for the
> root of the tree, we can simply use that instead of looping over
> the top level roles.
> 
> Overall against master this branch shows negligeable differences
> in both the *BENCHMARK_HierarchicalAllocator_*.LargeAndSmallQuota*
> and *BENCHMARK_HierarchicalAllocator_*NonQuotaVsQuota/4 benchmarks.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 1fd8b021c9954c37533dc193b3148def5ff53071

> 
> 
> Diff: https://reviews.apache.org/r/70382/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message