mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70395: Enhanced HierarchicalAllocatorTest.QuotaWithNestedRoleReservation.
Date Fri, 05 Apr 2019 02:47:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70395/
-----------------------------------------------------------

(Updated April 5, 2019, 2:47 a.m.)


Review request for mesos and Meng Zhu.


Changes
-------

Made the comments clearer per meng's feedback.


Bugs: MESOS-9688 and MESOS-9691
    https://issues.apache.org/jira/browse/MESOS-9688
    https://issues.apache.org/jira/browse/MESOS-9691


Repository: mesos


Description
-------

This test missed an issue in https://reviews.apache.org/r/70393/
because it was only checking that the quota consumption for "a"
was >= the subrole "a/b" reservation. Updated this test to ensure
that the quota consumption is exactly equal to the subrole "a/b"
reservation.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp c7edee2f49bfac0796c9506265d3bb766416ee63 


Diff: https://reviews.apache.org/r/70395/diff/2/

Changes: https://reviews.apache.org/r/70395/diff/1-2/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message