mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70382: Avoid looping over role allocations during headroom computation.
Date Thu, 04 Apr 2019 21:49:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70382/#review214386
-----------------------------------------------------------


Fix it, then Ship it!





src/master/allocator/mesos/hierarchical.cpp
Lines 1793-1803 (original), 1791-1801 (patched)
<https://reviews.apache.org/r/70382/#comment300592>

    Add a todo to simplify this as well?


- Meng Zhu


On April 4, 2019, 12:03 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70382/
> -----------------------------------------------------------
> 
> (Updated April 4, 2019, 12:03 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that the sorter exposes the allocation information for the
> root of the tree, we can simply use that instead of looping over
> the top level roles.
> 
> Overall against master this branch shows negligeable differences
> in both the *BENCHMARK_HierarchicalAllocator_*.LargeAndSmallQuota*
> and *BENCHMARK_HierarchicalAllocator_*NonQuotaVsQuota/4 benchmarks.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 1fd8b021c9954c37533dc193b3148def5ff53071

> 
> 
> Diff: https://reviews.apache.org/r/70382/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message