mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70392: Added a NOTE/TODO to track reservations in the allocator's roles map.
Date Thu, 04 Apr 2019 21:19:12 GMT


> On April 4, 2019, 7:27 p.m., Meng Zhu wrote:
> > We probably want a ticket for this?
> > 
> > IMO, instead of `hashmap<string, Role>`. We should pull the tree structure
of the sorter here and have `hashmap<std::string, Node*>` or something similar.

Yeah a ticket sounds like a good idea, storing the tree in the allocator makes sense, but
making `roles` more coherent in the short term would be good to do as it's a much smaller
change.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70392/#review214374
-----------------------------------------------------------


On April 4, 2019, 6:57 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70392/
> -----------------------------------------------------------
> 
> (Updated April 4, 2019, 6:57 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, the `roles` map does not track a role if it has a
> reservation but no allocation or framework subscription. This
> was an oversight and is unintuitive.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 9d51aebb8862436b36da87875f6e821b711b8c56

> 
> 
> Diff: https://reviews.apache.org/r/70392/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message