mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70362: Added the `mesos::csi::v1::Client` wrapper.
Date Thu, 04 Apr 2019 20:40:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70362/#review214380
-----------------------------------------------------------


Ship it!




It would be great if we could briefly mention in the summary what the changes of this one
on top on the v0 client are.


src/csi/v1_client.hpp
Lines 32 (patched)
<https://reviews.apache.org/r/70362/#comment300571>

    Already saw this on in `csi::v0`. Great to see strongly typed errors.


- Benjamin Bannier


On April 2, 2019, 8:20 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70362/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 8:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9623
>     https://issues.apache.org/jira/browse/MESOS-9623
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the `mesos::csi::v1::Client` wrapper.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
>   src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3 
>   src/csi/v1_client.hpp PRE-CREATION 
>   src/csi/v1_client.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70362/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message