mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 70382: Avoid looping over role allocations during headroom computation.
Date Thu, 04 Apr 2019 19:03:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70382/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Repository: mesos


Description
-------

Now that the sorter exposes the allocation information for the
root of the tree, we can simply use that instead of looping over
the top level roles.

Overall against master this branch shows negligeable differences
in both the *BENCHMARK_HierarchicalAllocator_*.LargeAndSmallQuota*
and *BENCHMARK_HierarchicalAllocator_*NonQuotaVsQuota/4 benchmarks.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 1fd8b021c9954c37533dc193b3148def5ff53071 


Diff: https://reviews.apache.org/r/70382/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message