mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70388: Replaced os.path.exists() with a proper check of automake flags.
Date Thu, 04 Apr 2019 18:13:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70388/#review214371
-----------------------------------------------------------



Bad review!

Reviews applied: [70388, 70387]

Error:
2019-04-04 18:13:29 URL:https://reviews.apache.org/r/70387/diff/raw/ [112367/112367] ->
"70387.patch" [1]
70387.patch:1990: trailing whitespace.
 
70387.patch:2015: trailing whitespace.
 
70387.patch:2025: trailing whitespace.
 
70387.patch:2072: trailing whitespace.
 
70387.patch:2093: trailing whitespace.
 
error: missing binary patch data for '3rdparty/glog-0.4.0.tar.gz'
error: binary patch does not apply to '3rdparty/glog-0.4.0.tar.gz'
error: 3rdparty/glog-0.4.0.tar.gz: patch does not apply

- Mesos Reviewbot


On April 4, 2019, 9:48 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70388/
> -----------------------------------------------------------
> 
> (Updated April 4, 2019, 9:48 a.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-9699
>     https://issues.apache.org/jira/browse/MESOS-9699
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced os.path.exists() with a proper check of automake flags.
> 
> 
> Diffs
> -----
> 
>   src/python/native_common/ext_modules.py.in eee56a94705b561794b1ee8e495701c0bba695f1

> 
> 
> Diff: https://reviews.apache.org/r/70388/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message