mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70363: Extended `CSIClientTest` to test the CSI v1 client wrapper.
Date Wed, 03 Apr 2019 23:04:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70363/#review214347
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70313, 70314, 70315, 70316, 70331, 70245, 70168, 70247, 70248, 70213, 70214,
70216, 70215, 70217, 70284, 70222, 70285, 70223, 70225, 70302, 70303, 70321, 70360, 70361,
70362, 70363]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On April 1, 2019, 11:22 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70363/
> -----------------------------------------------------------
> 
> (Updated April 1, 2019, 11:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9623
>     https://issues.apache.org/jira/browse/MESOS-9623
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Extended `CSIClientTest` to test the CSI v1 client wrapper.
> 
> 
> Diffs
> -----
> 
>   src/tests/csi_client_tests.cpp c8f3f04e6bff40d62dd0f85fcc146d71fa9e5d34 
>   src/tests/mock_csi_plugin.hpp 6897fbc878f1e2f5b9e9c402b09358c187af79a0 
>   src/tests/mock_csi_plugin.cpp 10245705ab39872da0fef1afd02213e2c7f345cb 
>   src/tests/storage_local_resource_provider_tests.cpp 0fbd602a196c6994c587e2918675ac6a5446aa1e

> 
> 
> Diff: https://reviews.apache.org/r/70363/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message