mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Review Request 70379: Added validation that the principal stays the same on resubscription.
Date Wed, 03 Apr 2019 16:04:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70379/
-----------------------------------------------------------

Review request for mesos and Gastón Kleiman.


Bugs: MESOS-2842
    https://issues.apache.org/jira/browse/MESOS-2842


Repository: mesos


Description
-------

Added validation that the principal stays the same on a framework resubscription.
This solves MESOS-2842.

There are at least two objectionable places in this patch - see TODO in the diff.


Diffs
-----

  src/master/master.hpp 94891af9deeaddb3333fc9d6eabb243aed97f7b7 
  src/master/master.cpp cf5caa0893ba1387a1f3a9d129ecd7d974f776bd 


Diff: https://reviews.apache.org/r/70379/diff/1/


Testing
-------

make check

Now the two failing tests from https://reviews.apache.org/r/70377/ pass.


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message