mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Wed, 03 Apr 2019 15:21:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review214334
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Lines 565 (patched)
<https://reviews.apache.org/r/70288/#comment300534>

    This line breaks our image caching functionality. Here the `reference` is **normalized**
in the beginning of `RegistryPullerProcess::_pull`, so for some public images (like alpine)
in Docker Hub, it will have the `library/` prefix in front of the actual image name and it
will be checkpointed in our image cache (i.e., what is save in the cache is `library/alpine`
rather than `alpine`). Next time when we try to launch another container with the same image,
we will look up `alpine` in the cache and we will not find anything since what is saved in
cache is `library/alpine`. This will cause our cache is always missed.


- Qian Zhang


On April 3, 2019, 4:01 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated April 3, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/uri/fetchers/docker.cpp a87d7f086378539e6c8048e935389919a1164fbc 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message