mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Wed, 03 Apr 2019 08:34:16 GMT


> On April 2, 2019, 9:18 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
> > Lines 548 (patched)
> > <https://reviews.apache.org/r/70288/diff/3/?file=2136767#file2136767line548>
> >
> >     Can we use `layerIds` in this for loop instead of `digests`? If so, then we
do not need the `if (digest == manifest.config().digest())` check below (since `layerIds`
does not contain config digest) and we actually do not need this `digests` parameter for this
`____pull` method.
> 
> Gilbert Song wrote:
>     I thought about that, but still prefer `digests`. because:
>     
>     `digests` ~ contents that really got downloaded to the staging dir.
>     `layderIds` ~ from the manifest, some of them are not in the staging dir.
>     
>     if we add check to skip those layers not in staging dir, then the rm() error msg
would become meaningless.

Agree!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review214264
-----------------------------------------------------------


On April 3, 2019, 4:01 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated April 3, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/uri/fetchers/docker.cpp a87d7f086378539e6c8048e935389919a1164fbc 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message