mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Wed, 03 Apr 2019 08:22:10 GMT


> On April 2, 2019, 9:18 p.m., Qian Zhang wrote:
> > src/uri/fetchers/docker.cpp
> > Line 842 (original), 742 (patched)
> > <https://reviews.apache.org/r/70288/diff/3/?file=2136769#file2136769line843>
> >
> >     Is it possible that there is no `Content-Type`? Should we treat no `Content-Type`
as v2 s1 by default
> 
> Gilbert Song wrote:
>     I don't think so.
>     
>     Also, our old behavior regards that as a failure.

I do not think our old behavior regards that as a failure: https://github.com/apache/mesos/blob/1.7.2/src/uri/fetchers/docker.cpp#L682:L704
, if there is not `Content-Type`, we just parse it as v2 s1 manifest by default.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review214264
-----------------------------------------------------------


On April 3, 2019, 4:01 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated April 3, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/uri/fetchers/docker.cpp a87d7f086378539e6c8048e935389919a1164fbc 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message