mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 70290: Fixed docker fetcher plugin unit test for v2s2 change.
Date Wed, 03 Apr 2019 06:51:26 GMT


> On March 25, 2019, 1:23 a.m., Qian Zhang wrote:
> > src/tests/uri_fetcher_tests.cpp
> > Lines 380 (patched)
> > <https://reviews.apache.org/r/70290/diff/1/?file=2133766#file2133766line380>
> >
> >     Can we add a comment to describe why the image used in this test is a v2 s2
image?

new patch now.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70290/#review213969
-----------------------------------------------------------


On April 2, 2019, 1:11 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70290/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 1:11 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed docker fetcher plugin unit test for v2s2 change.
> 
> 
> Diffs
> -----
> 
>   src/tests/uri_fetcher_tests.cpp f8bacc0bb9e30917f0792d25f172534a0ec27a2c 
> 
> 
> Diff: https://reviews.apache.org/r/70290/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message