mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70369: Fixed compile error with a built-in logrotate module.
Date Wed, 03 Apr 2019 05:24:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70369/#review214316
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On April 2, 2019, 11:56 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70369/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 11:56 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Meng Zhu.
> 
> 
> Bugs: MESOS-9564
>     https://issues.apache.org/jira/browse/MESOS-9564
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch gets rid of redundant use of `Error` wrapper for an error
> message that is passed to EXIT macro. This fixes a compile error on
> Mesos versions that do not support output operator for `Error` type.
> 
> 
> Diffs
> -----
> 
>   src/slave/container_loggers/logrotate.cpp 528dea48fa2c470c176ee2ad07850598c628f82f

> 
> 
> Diff: https://reviews.apache.org/r/70369/diff/1/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message