mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Wed, 03 Apr 2019 03:53:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review214310
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 447-458 (patched)
<https://reviews.apache.org/r/70288/#comment300518>

    We need to check if the config exists in the store before moving it, otherwise the unit
test https://reviews.apache.org/r/70366/ will fail:
    
    ```
    E0402 20:01:52.671329  1856 slave.cpp:6464] Container 'a81b645b-e58a-47ff-b790-70cae2de900a'
for executor 'test' of framework 0e53f4ec-517f-4507-b1a5-d66677ee2f01-0001 failed to start:
Failed to find docker manifest config at '/opt/qzhang/mesos/store/docker/staging/sGvKLO/sha256:5cb3aa00f89934411ffba5c063a9bc98ace875d8f92e77d0029543d9f2ef4ad0'
    ```


- Qian Zhang


On April 3, 2019, 9:08 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated April 3, 2019, 9:08 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/uri/fetchers/docker.cpp a87d7f086378539e6c8048e935389919a1164fbc 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message