mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 70371: Added a test to ensure subroles reservations are tracked correctly.
Date Wed, 03 Apr 2019 00:41:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70371/#review214299
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70352, 70353, 70371]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On April 2, 2019, 3:29 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70371/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 3:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9688
>     https://issues.apache.org/jira/browse/MESOS-9688
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that a subrole's reservation is counted towards
> its parent's reservation when accounting consumed quota.
> See MESOS-9688.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 39e209b4162fa743540e194912f546e9496b20b8

> 
> 
> Diff: https://reviews.apache.org/r/70371/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> The test does not pass without r/70353.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message