mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70216: Cleanup the recovery logic for refactoring SLRP.
Date Wed, 03 Apr 2019 00:00:59 GMT


> On March 20, 2019, 3:13 p.m., Benjamin Bannier wrote:
> > src/csi/v0_volume_manager_process.hpp
> > Lines 176 (patched)
> > <https://reviews.apache.org/r/70216/diff/2/?file=2132476#file2132476line176>
> >
> >     Can or should this be `const`?
> 
> Chun-Hung Hsiao wrote:
>     Although this can, it has a side effect that's not directly related to the data members.
Given this, and given that it's an actor in a non-copyable object, I'd prefer not adding the
`const` qualifier to give an illusion that it's side-effect free. WDYT?

Dropping this for now. Feel free to reopen.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70216/#review213840
-----------------------------------------------------------


On March 28, 2019, 7:55 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70216/
> -----------------------------------------------------------
> 
> (Updated March 28, 2019, 7:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-9622
>     https://issues.apache.org/jira/browse/MESOS-9622
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In addition to perform volume state recovery, the `recoverVolumes`
> function also recovers service manager and preparing services now. The
> whole logic will be moved out from SLRP to v0 `VolumeManager` later.
> 
> During volume state recovery, we no longer recover all volumes to steady
> states, since transient states are properly handled in SLRP. To simplify
> the recovery logic, a `publishVolume` method that conforms to the volume
> manager's `publishVolume` is introduced.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 2711503cdb58cb9b34af8c9fad0908c5f788a2af

>   src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93

> 
> 
> Diff: https://reviews.apache.org/r/70216/diff/6/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message