mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70361: Added spec inclusion header and type helpers for CSI v1.
Date Tue, 02 Apr 2019 14:57:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70361/#review214280
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/csi/v1.hpp
Lines 69 (patched)
<https://reviews.apache.org/r/70361/#comment300493>

    ADL should only be triggered for `message` values with types from `csi::v1`, right? Or
am I missing something?



include/mesos/csi/v1.hpp
Lines 79 (patched)
<https://reviews.apache.org/r/70361/#comment300494>

    Do you think it would make sense to assert that the conversion is successful?
    
    ```
    google::protobuf::util::Status status =
      google::protobuf::util::MessageToJsonString(message, &output);
      
      CHECK(status.ok())
        << "Could not convert message to string: " << status.error_message();
    ```



src/csi/v1.cpp
Lines 32 (patched)
<https://reviews.apache.org/r/70361/#comment300495>

    Can we just use the proto message differencer here? If not, let's document why not.



src/csi/v1.cpp
Lines 40 (patched)
<https://reviews.apache.org/r/70361/#comment300496>

    Ditto.


- Benjamin Bannier


On April 2, 2019, 8:20 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70361/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 8:20 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9624
>     https://issues.apache.org/jira/browse/MESOS-9624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec inclusion header and type helpers for CSI v1.
> 
> 
> Diffs
> -----
> 
>   include/mesos/csi/v1.hpp PRE-CREATION 
>   src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
>   src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3 
>   src/csi/v1.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70361/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message