mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 70360: Bundled CSI spec 1.1.0.
Date Tue, 02 Apr 2019 14:34:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70360/#review214279
-----------------------------------------------------------



Could you please update this for the issues I raised in https://reviews.apache.org/r/70302

* avoid patching upstream tarball, do file movements in autotools or cmake setup
* make sure generated csi headers end up in correct subdirectory with autotools

Other than that this LGTM.

- Benjamin Bannier


On April 2, 2019, 8:15 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70360/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 8:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-9624
>     https://issues.apache.org/jira/browse/MESOS-9624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The CSI v1 bundle is generated through following `3rdparty/csi.md`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 1999dd20964da96bc5acfbd47cb80d4ca6f734b9 
>   3rdparty/Makefile.am 98a2623b34132885279bea6135c0da4ffc8c59cf 
>   3rdparty/cmake/Versions.cmake 972c706a18bfce45af6c2632b326606052888b02 
>   3rdparty/csi-1.1.0.tar.gz PRE-CREATION 
>   3rdparty/versions.am 24381073f4c77d92c5ba62f54bb2194bf041ee6c 
>   configure.ac 5302e666a524de37713f8caae33e5671531dc8a9 
>   src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
>   src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3 
>   src/cmake/MesosProtobuf.cmake 09074d77a1df5076c6e51292523ce994a77a88f2 
> 
> 
> Diff: https://reviews.apache.org/r/70360/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message