mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Tue, 02 Apr 2019 14:13:13 GMT


> On March 25, 2019, 3:56 p.m., Qian Zhang wrote:
> > src/uri/fetchers/docker.cpp
> > Line 1028 (original), 956 (patched)
> > <https://reviews.apache.org/r/70288/diff/1/?file=2133764#file2133764line1087>
> >
> >     I think this will make `urlFetchBlob` not working as what we expect. The reason
is in your implementation we will fetch manifest only once (either v2 s1 or v2 s2, so there
is only one manifest in staging dir), but originally we will fetch manifest twice (v2 s1 for
all platforms and v2 s2 only for Windows). So now in `urlFetchBlob` we will read and parse
the same manifest again (because there is only one manifest) which I think is not what we
want.
> 
> Gilbert Song wrote:
>     I don't understand. On windows, we will read and parse v2s2 manifest. For windows
images, we should always fetch v2s2. Previous method is not a graceful solution.
>     
>     Anyway, our following patch will address all issues.

> I don't understand. On windows, we will read and parse v2s2 manifest. For windows images,
we should always fetch v2s2. Previous method is not a graceful solution.

Agree. But now how we fetch a blob for Windows is, we fetch it based on layer digest first,
if it failed, then we fetch it based on layer's foreign urls. I do suggest we fetch blobs
based on layer's media type as I mentioned here: https://reviews.apache.org/r/70289/#comment300090
, in that way, we will fetch a blob only once (rather than try one way first and if it fails
try another way), and another benefit is we will not have any Windows specific code for fetching
blobs.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review213964
-----------------------------------------------------------


On April 2, 2019, 4:11 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 4:11 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/uri/fetchers/docker.cpp a87d7f086378539e6c8048e935389919a1164fbc 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message