mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70365: Added protobuf for docker v2 schema2 config path in 'Image'.
Date Tue, 02 Apr 2019 13:17:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70365/#review214273
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/docker/message.proto
Lines 38 (patched)
<https://reviews.apache.org/r/70365/#comment300481>

    I see in https://reviews.apache.org/r/70288 (the method `RegistryPullerProcess::____pull`),
what we set into this field is actually the config digest rather than a path, so maybe we
should name it `config_id` which is also consistent with the above `layer_ids` field.


- Qian Zhang


On April 2, 2019, 4:10 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70365/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 4:10 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added protobuf for docker v2 schema2 config path in 'Image'.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto a55ac9010d5e5b5691ec34b6c342e57811aee4ce

> 
> 
> Diff: https://reviews.apache.org/r/70365/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message