mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 70368: Initialized resource provider manager earlier when recovering.
Date Tue, 02 Apr 2019 08:35:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70368/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-9667
    https://issues.apache.org/jira/browse/MESOS-9667


Repository: mesos


Description
-------

When recovering and reusing the same agent ID the resource provider
manager can be initialized before e.g., recovering executors. This patch
move the initialization to such an earlier point. This e.g., allows to
successfully publish resources via the manager when HTTP-based executors
resubscribe which previously ran into an assertion failure.

If the agent ID is not reused we still need to wait for the agent to
register with the master which would assign an agent ID. In that case we
do not expect any executors to resubscribe.


Diffs
-----

  src/slave/slave.cpp 5373cee5d30c2403497939eeba2ee5405117237e 
  src/tests/slave_tests.cpp 528a25a837513f153de2a5e89897440144385633 


Diff: https://reviews.apache.org/r/70368/diff/1/


Testing
-------

* `make check`
* the test fails without the agent change
* ran the test for 17000 iterations without failures (failure rate <1% with 66% certainty)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message