mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 70288: Supported docker manifest v2 schema2.
Date Tue, 02 Apr 2019 08:05:22 GMT


> On March 25, 2019, 12:56 a.m., Qian Zhang wrote:
> > src/uri/fetchers/docker.cpp
> > Line 1028 (original), 956 (patched)
> > <https://reviews.apache.org/r/70288/diff/1/?file=2133764#file2133764line1087>
> >
> >     I think this will make `urlFetchBlob` not working as what we expect. The reason
is in your implementation we will fetch manifest only once (either v2 s1 or v2 s2, so there
is only one manifest in staging dir), but originally we will fetch manifest twice (v2 s1 for
all platforms and v2 s2 only for Windows). So now in `urlFetchBlob` we will read and parse
the same manifest again (because there is only one manifest) which I think is not what we
want.

I don't understand. On windows, we will read and parse v2s2 manifest. For windows images,
we should always fetch v2s2. Previous method is not a graceful solution.

Anyway, our following patch will address all issues.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70288/#review213964
-----------------------------------------------------------


On April 2, 2019, 1:05 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70288/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 1:05 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6934
>     https://issues.apache.org/jira/browse/MESOS-6934
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported docker manifest v2 schema2.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 644c560ac1b29517811b0f30036285e9793a7c81

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp e0f2371bcf0ae1fb5561861af945b03138603f2c

>   src/uri/fetchers/docker.cpp ffb519469c9615af369ac2298358bc413e5cdd63 
> 
> 
> Diff: https://reviews.apache.org/r/70288/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message