mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70321: Cleaned up `mesos::csi::v0::Client` interface.
Date Tue, 02 Apr 2019 06:13:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70321/
-----------------------------------------------------------

(Updated April 2, 2019, 6:13 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Rebased and addressed Benjamin's comments.


Bugs: MESOS-9624
    https://issues.apache.org/jira/browse/MESOS-9624


Repository: mesos


Description
-------

Since per-CSI-call metrics are no longer implemented, there is very less
value to keep the `mesos::csi::v0::RPC` enum, which is tightly coupled
with `mesos::csi::v0::Client`. Therefore, the enum and its header are
removed.

The header and implementation file for `mesos::csi::v0::Client` is also
renamed for future CSI v1 support.


Diffs (updated)
-----

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3 
  src/csi/client.hpp c2583cf4c0d2abc38d65ddc801cae3696a8080a9 
  src/csi/client.cpp 9e17f5bcb902470045dac704f2471d2962336e48 
  src/csi/rpc.hpp b2502ceb319638038b4d151965f6226db675f96b 
  src/csi/rpc.cpp e8a2770a6d8ae48a717ed93fa872e9edee45e618 
  src/csi/service_manager.cpp PRE-CREATION 
  src/csi/v0_client.hpp PRE-CREATION 
  src/csi/v0_volume_manager.cpp PRE-CREATION 
  src/csi/v0_volume_manager_process.hpp PRE-CREATION 
  src/tests/csi_client_tests.cpp c8f3f04e6bff40d62dd0f85fcc146d71fa9e5d34 
  src/tests/storage_local_resource_provider_tests.cpp 0fbd602a196c6994c587e2918675ac6a5446aa1e



Diff: https://reviews.apache.org/r/70321/diff/3/

Changes: https://reviews.apache.org/r/70321/diff/2-3/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message