mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI versions.
Date Tue, 02 Apr 2019 05:54:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/
-----------------------------------------------------------

(Updated April 2, 2019, 5:54 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.


Changes
-------

Rebased and took Benjamin's suggestion.


Bugs: MESOS-9639
    https://issues.apache.org/jira/browse/MESOS-9639


Repository: mesos


Description
-------

Since the fine-grained version-specific per-CSI-call metrics are not
very useful for operators, and most informations are highly correlated
to per-operation metrics, these metrics are aggregated and made CSI
version agnostic.


Diffs (updated)
-----

  docs/monitoring.md 239077b354d1af73d5b0a358e19d67574b2093a6 
  src/csi/metrics.hpp PRE-CREATION 
  src/csi/metrics.cpp PRE-CREATION 
  src/csi/service_manager.cpp PRE-CREATION 
  src/csi/v0_volume_manager.cpp PRE-CREATION 
  src/tests/storage_local_resource_provider_tests.cpp 0fbd602a196c6994c587e2918675ac6a5446aa1e



Diff: https://reviews.apache.org/r/70225/diff/7/

Changes: https://reviews.apache.org/r/70225/diff/6-7/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message