mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70168: Refactored SLRP with `ServiceManager` to manage container lifecycles.
Date Tue, 02 Apr 2019 05:26:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/
-----------------------------------------------------------

(Updated April 2, 2019, 5:26 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht.


Changes
-------

Rebased and addressed Benjamin's comment.


Bugs: MESOS-9632
    https://issues.apache.org/jira/browse/MESOS-9632


Repository: mesos


Description
-------

Container management is moved out from SLRP to `ServiceManager`. It is
agnostic to CSI versions, so can be used to manage plugin containers for
both CSI v0 and v1 plugins.

This patch squashes the changes from r/70169.


Diffs (updated)
-----

  src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 
  src/Makefile.am 7c2131a9daf16d49e8e8d75b12f019e5c4df1da3 
  src/csi/service_manager.hpp PRE-CREATION 
  src/csi/service_manager.cpp PRE-CREATION 
  src/resource_provider/storage/provider.cpp cc7944c73e24182ad9e5ec6f21b88d0f6f2974d5 
  src/resource_provider/storage/provider_process.hpp a5536b3d735e01eb1c4dc52d0602d973155f3c93



Diff: https://reviews.apache.org/r/70168/diff/12/

Changes: https://reviews.apache.org/r/70168/diff/11-12/


Testing
-------

Testing done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message