mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 70355: Switched to used `/proc/1/ns/pid` to test pid namespaces.
Date Tue, 02 Apr 2019 03:49:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70355/#review214254
-----------------------------------------------------------


Ship it!




Ship It!

- James Peach


On April 2, 2019, 1:26 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70355/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 1:26 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, James Peach, and Qian Zhang.
> 
> 
> Bugs: MESOS-9529
>     https://issues.apache.org/jira/browse/MESOS-9529
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, we're using `/proc/self/ns/pid` to test pid namespaces. This
> is proven to be problematic because the kernel will resolve correctly
> even if the `/proc` is not re-mounted in the new pid namespace.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 5446dd9f9842c6ce100f7b2e4c2b120ebce41e43

>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp ac9a6b803a6ba22a4e1fda96c825dbbfd779d915

>   src/tests/default_executor_tests.cpp 7d7b11383e955ebaecdc37bbde5ed39a36154e28 
> 
> 
> Diff: https://reviews.apache.org/r/70355/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> This test will fail on some PidNamespace tests, which will be fixed in a subsequent patch.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message