mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 70354: Refactored the UCR docker store to construct 'Image' proto at pullers.
Date Tue, 02 Apr 2019 03:21:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70354/#review214252
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/image_tar_puller.cpp
Lines 298 (patched)
<https://reviews.apache.org/r/70354/#comment300463>

    s/dockerImage/image/



src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
Line 429 (original), 429 (patched)
<https://reviews.apache.org/r/70354/#comment300466>

    Ditto.



src/tests/containerizer/provisioner_docker_tests.cpp
Line 328 (original), 329 (patched)
<https://reviews.apache.org/r/70354/#comment300469>

    Comment (`return list`) need to be updated?


- Qian Zhang


On April 2, 2019, 9:21 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70354/
> -----------------------------------------------------------
> 
> (Updated April 2, 2019, 9:21 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Ilya Pronin, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-9694
>     https://issues.apache.org/jira/browse/MESOS-9694
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This refactoring is needed for supporting docker manifest v2s2 because
> the puller has to let the docker store knows the v1 config, and this
> is also needed for garbage collecting the v1 config in the image layer
> store.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/image_tar_puller.hpp b5ec924b6c54fa507965248b6cb06513b0c5c256

>   src/slave/containerizer/mesos/provisioner/docker/image_tar_puller.cpp 3a33388f19b8c6a949661ed9f576cb4ca694302b

>   src/slave/containerizer/mesos/provisioner/docker/message.proto a55ac9010d5e5b5691ec34b6c342e57811aee4ce

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp cfafd442af3b164050257ff945226db2596555f1

>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 847eb9a74c353fc0561ed29f12b9868a8010940d

>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp a79f2ad107aeb3ebfda22e80a85f83ac9685fa85

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 926fab19b6de7e9b3625ee5aa483817c804457c1

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2

>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6

>   src/tests/containerizer/provisioner_docker_tests.cpp a2a7f11eeb533d7790890988061612e11a798067

> 
> 
> Diff: https://reviews.apache.org/r/70354/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message