mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70353: Fixed quota enforcement in the presence of subrole reservations.
Date Tue, 02 Apr 2019 00:47:07 GMT


> On April 1, 2019, 5:31 p.m., Meng Zhu wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Lines 1710-1713 (original), 1711-1717 (patched)
> > <https://reviews.apache.org/r/70353/diff/1/?file=2136497#file2136497line1711>
> >
> >     why the change here? It appears to me that both produce the same result and
the original code is more efficient?

OK, looks like although `quotaRoleSorter` is hierarchical, it does not track allocations of
sub-roles (since no sub-roles can have quotas). Ah, this is quite subtle to me (I never thought
of this). Let's add some comments here.

Also, this complexity lets me wonder can we get rid of the quotaRoleSorter for good?


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70353/#review214248
-----------------------------------------------------------


On April 1, 2019, 4:57 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70353/
> -----------------------------------------------------------
> 
> (Updated April 1, 2019, 4:57 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9688 and MESOS-9691
>     https://issues.apache.org/jira/browse/MESOS-9688
>     https://issues.apache.org/jira/browse/MESOS-9691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current reservation tracking in the allocator does not take
> into account hierarchical roles. As a result, when a subrole
> (e.g. "a/b") has a reservation, it does not count towards the
> role's (e.g. "a") quota. This patch updates the reservation
> tracking for each roel to include all all subrole reservations.
> 
> In addition, the quota consumption tracking is fixed to correctly
> handle subroles.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp b9bddd31c581d8166bf6497d5d19c585b2b108a3

> 
> 
> Diff: https://reviews.apache.org/r/70353/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tests will be needed.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message