mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 70353: Fixed quota enforcement in the presence of subrole reservations.
Date Mon, 01 Apr 2019 23:57:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70353/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Bugs: MESOS-9688 and MESOS-9691
    https://issues.apache.org/jira/browse/MESOS-9688
    https://issues.apache.org/jira/browse/MESOS-9691


Repository: mesos


Description
-------

The current reservation tracking in the allocator does not take
into account hierarchical roles. As a result, when a subrole
(e.g. "a/b") has a reservation, it does not count towards the
role's (e.g. "a") quota. This patch updates the reservation
tracking for each roel to include all all subrole reservations.

In addition, the quota consumption tracking is fixed to correctly
handle subroles.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp b9bddd31c581d8166bf6497d5d19c585b2b108a3 


Diff: https://reviews.apache.org/r/70353/diff/1/


Testing
-------

make check

Tests will be needed.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message