mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 70345: Simplified quota chopping logic in the allocator.
Date Mon, 01 Apr 2019 19:37:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70345/
-----------------------------------------------------------

(Updated April 1, 2019, 12:37 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Addressed Ben's comment.


Repository: mesos


Description
-------

This patch refactors the `shrinkResources()` helper
to take in a target `ResourceQuantities`.
Due to the absent-means-zero semantic of
`class ResourceQuantities`, we also change the function
to drop (shrink to zero) resources that are absent in
the input `ResourceQuantities`.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.cpp ef4f968a94d3a23c010202e27cc48cd10bbec2c0 


Diff: https://reviews.apache.org/r/70345/diff/3/

Changes: https://reviews.apache.org/r/70345/diff/2-3/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message