mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70345: Simplified quota chopping logic in the allocator.
Date Mon, 01 Apr 2019 18:45:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70345/#review214240
-----------------------------------------------------------



Looks good and cleans up the callers nicely! Just some suggestions based on our meetings


src/master/allocator/mesos/hierarchical.cpp
Lines 1638-1640 (patched)
<https://reviews.apache.org/r/70345/#comment300436>

    Personally, I feel this is intuitive (no special case: 0 leads to shrinking to 0) and
doesn't need calling out



src/master/allocator/mesos/hierarchical.cpp
Lines 1659-1663 (patched)
<https://reviews.apache.org/r/70345/#comment300439>

    Looks like we can just use a ResourceQuantities for this instead of pulling it out into
a map?



src/master/allocator/mesos/hierarchical.cpp
Lines 1953-1959 (original), 1950-1956 (patched)
<https://reviews.apache.org/r/70345/#comment300438>

    This reads a bit odd to pass "limits" as quantities, can we rename it to the surplus name
here instead of in the next patch?


- Benjamin Mahler


On March 29, 2019, 11:19 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70345/
> -----------------------------------------------------------
> 
> (Updated March 29, 2019, 11:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch refactors the `shrinkResources()` helper
> to take in a target `ResourceQuantities`.
> Due to the absent-means-zero semantic of
> `class ResourceQuantities`, we also change the function
> to drop (shrink to zero) resources that are absent in
> the input `ResourceQuantities`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp ef4f968a94d3a23c010202e27cc48cd10bbec2c0

> 
> 
> Diff: https://reviews.apache.org/r/70345/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message