mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 70346: Removed unused function `Resources::isScalarQuantity`.
Date Mon, 01 Apr 2019 15:39:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70346/#review214238
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On March 29, 2019, 11:25 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70346/
> -----------------------------------------------------------
> 
> (Updated March 29, 2019, 11:25 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The function was introduced when `class Resources` is
> used for resource quantities. In particular, it was
> used in API validation where users are asked to specify
> resource quantities using `Resources`. Since `ResourceQuantities`
> is introduced, the function is no longer needed.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 62b6b0ce34b5e3d6451e70877f29a5b658e3213a 
>   include/mesos/v1/resources.hpp eb23359947957e991ca70ec321f4599916dca252 
>   src/common/resources.cpp f50fe560a3fb06aa53e6dd82dee3a41f586c6edd 
>   src/tests/resources_tests.cpp e67057cf13677e97c25e92353ab61493a4f2fcd9 
>   src/v1/resources.cpp d3a6194eaaaecf96ed4e2e558f502a98d2dbed4a 
> 
> 
> Diff: https://reviews.apache.org/r/70346/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message