mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] jieyu commented on a change in pull request #323: Fixed wrong example of --resources=filepath agent configuration.
Date Sat, 13 Apr 2019 03:34:56 GMT
jieyu commented on a change in pull request #323: Fixed wrong example of --resources=filepath
agent configuration.
URL: https://github.com/apache/mesos/pull/323#discussion_r275103202
 
 

 ##########
 File path: src/slave/flags.cpp
 ##########
 @@ -74,8 +74,8 @@ mesos::internal::slave::Flags::Flags()
       "\n"
       "To use JSON, pass a JSON-formatted string or use\n"
       "`--resources=filepath` to specify the resources via a file containing\n"
-      "a JSON-formatted string. `filepath` can be of the form\n"
-      "`file:///path/to/file` or `/path/to/file`.\n"
+      "a JSON-formatted string. `filepath` can only be of the form\n"
+      "`file:///path/to/file`.\n"
 
 Review comment:
   in fact, can you test if `file:///` works on the latest Mesos or Mesos 1.7? By reading
code, i doubt that `file:///` is going to work ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message