mesos-reviews mailing list archives: March 2019

Site index · List index
Message list1 · 2 · 3 · 4 · 5 · 6 · Next »Thread · Author · Date
Re: Review Request 70047: Updated build specific artefact generation.
Till Toenshoff via Review Board   Re: Review Request 70047: Updated build specific artefact generation. Fri, 01 Mar, 00:22
Till Toenshoff via Review Board   Re: Review Request 70047: Updated build specific artefact generation. Fri, 01 Mar, 00:40
Benjamin Bannier   Re: Review Request 70047: Updated build specific artefact generation. Fri, 01 Mar, 08:03
Till Toenshoff via Review Board   Re: Review Request 70047: Updated build specific artefact generation. Tue, 05 Mar, 18:46
Till Toenshoff via Review Board     Re: Review Request 70047: Updated build specific artefact generation. Wed, 06 Mar, 01:12
Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively.
Mesos Reviewbot   Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively. Fri, 01 Mar, 02:34
Mesos Reviewbot   Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively. Fri, 01 Mar, 02:55
Benjamin Bannier   Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively. Fri, 01 Mar, 15:48
Vinod Kone   Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively. Fri, 01 Mar, 22:11
Re: Review Request 67762: Added minimum capability check during master recovery.
Mesos Reviewbot   Re: Review Request 67762: Added minimum capability check during master recovery. Fri, 01 Mar, 05:15
Mesos Reviewbot   Re: Review Request 67762: Added minimum capability check during master recovery. Fri, 01 Mar, 05:24
Meng Zhu   Re: Review Request 67762: Added minimum capability check during master recovery. Tue, 05 Mar, 18:53
Mesos Reviewbot     Re: Review Request 67762: Added minimum capability check during master recovery. Wed, 06 Mar, 02:23
Joseph Wu     Re: Review Request 67762: Added minimum capability check during master recovery. Wed, 06 Mar, 19:10
Chun-Hung Hsiao Review Request 70080: Changed the `getResourceProviderId` helper to take a `Resources`. Fri, 01 Mar, 05:47
Benjamin Bannier   Re: Review Request 70080: Changed the `getResourceProviderId` helper to take a `Resources`. Fri, 01 Mar, 21:47
Chun-Hung Hsiao   Re: Review Request 70080: Changed the `getResourceProviderId` helper to take a `Resources`. Fri, 01 Mar, 23:41
Chun-Hung Hsiao Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 05:52
Mesos Reviewbot   Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 07:36
Mesos Reviewbot   Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 07:40
Chun-Hung Hsiao   Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 20:11
Benjamin Bannier     Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 22:15
Chun-Hung Hsiao       Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 22:58
Benjamin Bannier       Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Mon, 04 Mar, 11:21
Mesos Reviewbot     Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 22:39
Chun-Hung Hsiao     Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Fri, 01 Mar, 23:46
Benjamin Bannier       Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Mon, 04 Mar, 11:47
Chun-Hung Hsiao         Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Mon, 04 Mar, 19:47
Chun-Hung Hsiao       Re: Review Request 70081: Do not fail a task if it doesn't use resources from a failed provider. Mon, 04 Mar, 19:48
Re: Review Request 70049: Assured a set USER within RPM build.
Till Toenshoff via Review Board   Re: Review Request 70049: Assured a set USER within RPM build. Fri, 01 Mar, 09:52
Mesos Reviewbot   Re: Review Request 70049: Assured a set USER within RPM build. Sat, 02 Mar, 17:10
Mesos Reviewbot   Re: Review Request 70049: Assured a set USER within RPM build. Tue, 05 Mar, 21:43
Till Toenshoff via Review Board   Re: Review Request 70049: Assured a set USER within RPM build. Wed, 06 Mar, 01:01
Mesos Reviewbot     Re: Review Request 70049: Assured a set USER within RPM build. Wed, 06 Mar, 10:37
Chun-Hung Hsiao Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager. Fri, 01 Mar, 20:10
Benjamin Bannier   Re: Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager. Fri, 01 Mar, 22:17
Chun-Hung Hsiao     Re: Review Request 70082: Used `id::UUID` to index publishing requests in the RP manager. Fri, 01 Mar, 23:01
Chun-Hung Hsiao   Re: Review Request 70082: Converted `UUID` proto messages to `id::UUID` in the RP manager. Fri, 01 Mar, 23:48
Mesos Reviewbot     Re: Review Request 70082: Converted `UUID` proto messages to `id::UUID` in the RP manager. Sat, 02 Mar, 19:18
Mesos Reviewbot     Re: Review Request 70082: Converted `UUID` proto messages to `id::UUID` in the RP manager. Mon, 04 Mar, 22:07
Review Request 70084: Avoid dereferencing removed executors and launching containers for them.
Chun-Hung Hsiao   Review Request 70084: Avoid dereferencing removed executors and launching containers for them. Sat, 02 Mar, 00:08
Mesos Reviewbot   Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them. Sat, 02 Mar, 23:35
Mesos Reviewbot   Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them. Tue, 05 Mar, 00:16
Mesos Reviewbot Windows   Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them. Wed, 13 Mar, 22:10
Meng Zhu   Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them. Fri, 15 Mar, 02:40
Chun-Hung Hsiao     Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them. Fri, 15 Mar, 19:37
Chun-Hung Hsiao     Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them. Fri, 15 Mar, 19:39
Re: Review Request 69588: Removed outdated authorization logic for offer operations.
Chun-Hung Hsiao   Re: Review Request 69588: Removed outdated authorization logic for offer operations. Sat, 02 Mar, 00:54
Chun-Hung Hsiao   Re: Review Request 69588: Removed outdated authorization logic for offer operations. Sun, 03 Mar, 06:05
Chun-Hung Hsiao   Re: Review Request 69588: Removed outdated authorization logic for offer operations. Sun, 03 Mar, 06:16
Chun-Hung Hsiao   Re: Review Request 69588: Removed outdated authorization logic for offer operations. Sun, 03 Mar, 06:21
Mesos Reviewbot     Re: Review Request 69588: Removed outdated authorization logic for offer operations. Sun, 03 Mar, 08:41
Benjamin Bannier     Re: Review Request 69588: Removed outdated authorization logic for offer operations. Mon, 04 Mar, 10:37
Benjamin Bannier       Re: Review Request 69588: Removed outdated authorization logic for offer operations. Mon, 04 Mar, 10:40
Chun-Hung Hsiao       Re: Review Request 69588: Removed outdated authorization logic for offer operations. Mon, 04 Mar, 19:15
Chun-Hung Hsiao     Re: Review Request 69588: Removed outdated authorization logic for offer operations. Mon, 04 Mar, 19:15
Mesos Reviewbot       Re: Review Request 69588: Removed outdated authorization logic for offer operations. Tue, 05 Mar, 02:33
Qian Zhang Review Request 70085: Fixed a link error on Windows caused by volume gid manager. Sat, 02 Mar, 00:58
Mesos Reviewbot   Re: Review Request 70085: Fixed a link error on Windows caused by volume gid manager. Sat, 02 Mar, 21:27
Gilbert Song   Re: Review Request 70085: Fixed a link error on Windows caused by volume gid manager. Sun, 03 Mar, 01:28
Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.
Mesos Reviewbot   Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call. Sat, 02 Mar, 04:33
Re: Review Request 66344: Supported non-speculative operations on agent default resources.
Mesos Reviewbot   Re: Review Request 66344: Supported non-speculative operations on agent default resources. Sat, 02 Mar, 05:11
Mesos Reviewbot Windows   Re: Review Request 66344: Supported non-speculative operations on agent default resources. Thu, 14 Mar, 01:06
Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.
Mesos Reviewbot   Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics. Sat, 02 Mar, 06:05
James Peach   Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics. Sat, 02 Mar, 17:08
Mesos Reviewbot Windows   Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics. Wed, 13 Mar, 20:28
Re: Review Request 67177: Sorted container mounts by their target paths.
Mesos Reviewbot   Re: Review Request 67177: Sorted container mounts by their target paths. Sat, 02 Mar, 07:06
Mesos Reviewbot Windows   Re: Review Request 67177: Sorted container mounts by their target paths. Wed, 13 Mar, 22:07
Re: Review Request 66881: Added benchmark test for master metrics.
Mesos Reviewbot   Re: Review Request 66881: Added benchmark test for master metrics. Sat, 02 Mar, 08:09
Mesos Reviewbot Windows   Re: Review Request 66881: Added benchmark test for master metrics. Wed, 13 Mar, 23:12
Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.
Mesos Reviewbot   Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator. Sat, 02 Mar, 10:46
Mesos Reviewbot Windows   Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator. Wed, 13 Mar, 23:08
Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.
Mesos Reviewbot   Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`. Sat, 02 Mar, 13:05
Mesos Reviewbot Windows   Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`. Wed, 13 Mar, 20:25
Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.
Mesos Reviewbot   Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes. Sat, 02 Mar, 13:44
Chun-Hung Hsiao   Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes. Mon, 04 Mar, 19:23
Mesos Reviewbot Windows     Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes. Wed, 13 Mar, 21:30
Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`.
Benjamin Mahler   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Sat, 02 Mar, 15:24
Benjamin Bannier     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Mon, 04 Mar, 12:46
Meng Zhu     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Mon, 04 Mar, 22:50
Benjamin Mahler     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Thu, 07 Mar, 17:37
Meng Zhu     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Sat, 09 Mar, 01:56
Benjamin Bannier   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Mon, 04 Mar, 12:45
Meng Zhu     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Mon, 04 Mar, 22:50
Benjamin Bannier   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Mon, 04 Mar, 12:45
Benjamin Bannier   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Mon, 04 Mar, 12:45
Meng Zhu   Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Mon, 04 Mar, 22:50
Mesos Reviewbot     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Tue, 05 Mar, 11:43
Benjamin Bannier     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Tue, 05 Mar, 22:10
Meng Zhu     Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Sat, 09 Mar, 01:56
Mesos Reviewbot       Re: Review Request 70067: Added star operator for `Result`, `Try` and `Option`. Sat, 09 Mar, 04:42
Re: Review Request 69971: Removed an outdated comment in SLRP.
Mesos Reviewbot   Re: Review Request 69971: Removed an outdated comment in SLRP. Sat, 02 Mar, 16:22
Benjamin Bannier   Re: Review Request 69971: Removed an outdated comment in SLRP. Mon, 04 Mar, 10:47
Mesos Reviewbot   Re: Review Request 69971: Removed an outdated comment in SLRP. Tue, 05 Mar, 07:02
Benjamin Bannier Review Request 70088: Initialized pointers with `nullptr` instead of `0`. Sun, 03 Mar, 01:01
James Peach   Re: Review Request 70088: Initialized pointers with `nullptr` instead of `0`. Sun, 03 Mar, 02:36
Benjamin Bannier     Re: Review Request 70088: Initialized pointers with `nullptr` instead of `0`. Sun, 03 Mar, 16:08
Benjamin Bannier Review Request 70089: Removed non-ascii source code characters. Sun, 03 Mar, 01:01
Till Toenshoff via Review Board   Re: Review Request 70089: Removed non-ascii source code characters. Sun, 03 Mar, 14:05
Benjamin Bannier Review Request 70090: Addressed issues flagged by pylint-2.3.0. Sun, 03 Mar, 01:01
Armand Grillet   Re: Review Request 70090: Addressed issues flagged by pylint-2.3.0. Sun, 03 Mar, 08:17
Benjamin Bannier   Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1. Sun, 03 Mar, 11:39
Armand Grillet     Re: Review Request 70090: Addressed issues flagged by pylint-2.3.1. Sun, 03 Mar, 21:16
Benjamin Bannier Review Request 70092: Updated to pylint-2.3.0. Sun, 03 Mar, 01:01
Armand Grillet   Re: Review Request 70092: Updated to pylint-2.3.0. Sun, 03 Mar, 08:25
Benjamin Bannier     Re: Review Request 70092: Updated to pylint-2.3.0. Sun, 03 Mar, 10:36
Benjamin Bannier   Re: Review Request 70092: Updated to pylint-2.3.0. Sun, 03 Mar, 10:36
Benjamin Bannier     Re: Review Request 70092: Updated to pylint-2.3.1. Sun, 03 Mar, 11:39
Armand Grillet       Re: Review Request 70092: Updated to pylint-2.3.1. Sun, 03 Mar, 21:15
Benjamin Bannier Review Request 70093: Added license header to some Python source files. Sun, 03 Mar, 01:01
Alexander Rukletsov   Re: Review Request 70093: Added license header to some Python source files. Wed, 06 Mar, 16:11
Benjamin Bannier Review Request 70094: Fixed garbled license header. Sun, 03 Mar, 01:01
Mesos Reviewbot   Re: Review Request 70094: Fixed garbled license header. Sun, 03 Mar, 19:05
Alexander Rukletsov   Re: Review Request 70094: Fixed garbled license header. Wed, 06 Mar, 16:12
Benjamin Bannier Review Request 70095: Fixed cpplint issues in the Java bindings. Sun, 03 Mar, 01:01
Alexander Rukletsov   Re: Review Request 70095: Fixed cpplint issues in the Java bindings. Wed, 06 Mar, 13:58
Benjamin Bannier Review Request 70096: Moved cpplint configuration into dedicated file. Sun, 03 Mar, 01:01
Alexander Rukletsov   Re: Review Request 70096: Moved cpplint configuration into dedicated file. Wed, 06 Mar, 13:47
Benjamin Bannier Review Request 70097: Reverted untracked and unneeded cpplint modification. Sun, 03 Mar, 01:01
Alexander Rukletsov   Re: Review Request 70097: Reverted untracked and unneeded cpplint modification. Wed, 06 Mar, 10:13
Benjamin Bannier Review Request 70098: Made cpplint.patch reflect our modifications. Sun, 03 Mar, 01:01
Alexander Rukletsov   Re: Review Request 70098: Made cpplint.patch reflect our modifications. Wed, 06 Mar, 10:46
Alexander Rukletsov   Re: Review Request 70098: Made cpplint.patch reflect our modifications. Wed, 06 Mar, 13:45
Alexander Rukletsov   Re: Review Request 70098: Removed `support/cpplint.patch`. Thu, 07 Mar, 09:27
Benjamin Bannier Review Request 70099: Parameterized cpplint extension list via config instead of via patch. Sun, 03 Mar, 01:02
Alexander Rukletsov   Re: Review Request 70099: Parameterized cpplint extension list via config instead of via patch. Wed, 06 Mar, 13:25
Alexander Rukletsov   Re: Review Request 70099: Parameterized cpplint extension list via config instead of via patch. Wed, 06 Mar, 13:45
Benjamin Bannier Review Request 70100: Skipped pylint for cpplint.py per config instead of per patch. Sun, 03 Mar, 01:02
Alexander Rukletsov   Re: Review Request 70100: Skipped pylint for cpplint.py per config instead of per patch. Wed, 06 Mar, 13:27
Benjamin Bannier Review Request 70101: Removed manual author list cpplint.patch. Sun, 03 Mar, 01:02
Alexander Rukletsov   Re: Review Request 70101: Removed manual author list cpplint.patch. Wed, 06 Mar, 13:29
Benjamin Bannier Review Request 70102: Moved NULL check from cpplint into clang-tidy. Sun, 03 Mar, 01:02
Mesos Reviewbot   Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy. Sun, 03 Mar, 02:37
Mesos Reviewbot   Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy. Sun, 03 Mar, 11:11
Mesos Reviewbot   Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy. Sun, 03 Mar, 14:31
Mesos Reviewbot   Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy. Sun, 03 Mar, 22:03
Mesos Reviewbot   Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy. Mon, 04 Mar, 02:30
Tomasz Janiszewski   Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy. Mon, 04 Mar, 10:49
Alexander Rukletsov   Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy. Wed, 06 Mar, 13:41
Benjamin Bannier Review Request 70091: WIP: Added tox invocation to test stage. Sun, 03 Mar, 01:02
Mesos Reviewbot   Re: Review Request 70091: WIP: Added tox invocation to test stage. Sun, 03 Mar, 04:46
Mesos Reviewbot   Re: Review Request 70091: WIP: Added tox invocation to test stage. Sun, 03 Mar, 13:49
Benjamin Bannier   Re: Review Request 70091: Added tox invocation to test stage. Sun, 03 Mar, 17:09
Armand Grillet     Re: Review Request 70091: Added tox invocation to test stage. Sun, 03 Mar, 21:16
Benjamin Bannier Review Request 70103: Removed outdated scaling framework. Sun, 03 Mar, 12:06
Mesos Reviewbot   Re: Review Request 70103: Removed outdated scaling framework. Sun, 03 Mar, 16:54
Vinod Kone   Re: Review Request 70103: Removed outdated scaling framework. Thu, 07 Mar, 20:27
Benjamin Bannier Review Request 70104: Fixed broken Yaml in contributors database. Sun, 03 Mar, 12:29
Mesos Reviewbot   Re: Review Request 70104: Fixed broken Yaml in contributors database. Sun, 03 Mar, 21:24
Gilbert Song   Re: Review Request 70104: Fixed broken Yaml in contributors database. Mon, 04 Mar, 06:09
Re: Review Request 70105: Increased timeout in `generate-endpoint-help.py`.
Benjamin Bannier   Re: Review Request 70105: Increased timeout in `generate-endpoint-help.py`. Sun, 03 Mar, 18:03
Mesos Reviewbot     Re: Review Request 70105: Increased timeout in `generate-endpoint-help.py`. Mon, 04 Mar, 00:12
Vinod Kone     Re: Review Request 70105: Increased timeout in `generate-endpoint-help.py`. Tue, 05 Mar, 09:46
Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks.
Benjamin Bannier   Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks. Mon, 04 Mar, 10:46
Chun-Hung Hsiao   Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks. Mon, 04 Mar, 20:12
Benjamin Bannier   Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks. Mon, 04 Mar, 20:22
Chun-Hung Hsiao   Re: Review Request 69970: Made SLRP clean up mount directories for destroyed MOUNT disks. Tue, 05 Mar, 05:05
Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation.
Benjamin Bannier   Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation. Mon, 04 Mar, 12:54
Chun-Hung Hsiao   Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation. Mon, 04 Mar, 19:23
Benjamin Bannier     Re: Review Request 69954: Added a SLRP unit test for persistent block volume creation. Tue, 05 Mar, 09:58
Message list1 · 2 · 3 · 4 · 5 · 6 · Next »Thread · Author · Date
Box list
Apr 2019494
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338