From reviews-return-86681-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 28 05:18:32 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAB3318F8A for ; Thu, 28 Mar 2019 05:18:31 +0000 (UTC) Received: (qmail 46024 invoked by uid 500); 28 Mar 2019 05:18:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 45890 invoked by uid 500); 28 Mar 2019 05:18:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 45863 invoked by uid 99); 28 Mar 2019 05:18:30 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2019 05:18:30 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C8172E07DE; Thu, 28 Mar 2019 05:18:29 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B65CEC4021F; Thu, 28 Mar 2019 05:18:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1365585534487535878==" MIME-Version: 1.0 Subject: Review Request 70331: Updated test `AgentRegisteredWithNewId` for better code coverage. From: Chun-Hung Hsiao To: Benjamin Bannier , Jie Yu , Jan Schlicht Cc: Chun-Hung Hsiao , mesos Date: Thu, 28 Mar 2019 05:18:29 -0000 Message-ID: <20190328051829.24116.76729@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70331/ X-Sender: Chun-Hung Hsiao Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============1365585534487535878== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70331/ ----------------------------------------------------------- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MESOS-9655 https://issues.apache.org/jira/browse/MESOS-9655 Repository: mesos Description ------- This patch makes the `AgentRegisteredWithNewId` SLRP test to test the following scenarios: * Launch a task to access a volume imported through `CREATE_DISK`. * `CREATE_DISK` with a mismatched profile. * `DESTROY_DISK` with a `RAW` disk that has been published. Together with the `CreateDestroyPreprovisionedVolume` SLRP test, most scenarios of preprovisioned volumes are now covered. Diffs ----- src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87 Diff: https://reviews.apache.org/r/70331/diff/1/ Testing ------- sudo make check Run in repetition. Thanks, Chun-Hung Hsiao --===============1365585534487535878==--