From reviews-return-86676-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Mar 28 03:43:51 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 245E618D8E for ; Thu, 28 Mar 2019 03:43:51 +0000 (UTC) Received: (qmail 34943 invoked by uid 500); 28 Mar 2019 03:43:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34868 invoked by uid 500); 28 Mar 2019 03:43:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34825 invoked by uid 99); 28 Mar 2019 03:43:49 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Mar 2019 03:43:49 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 33181E0D27; Thu, 28 Mar 2019 03:43:49 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 219CDC40746; Thu, 28 Mar 2019 03:43:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2697739184919069624==" MIME-Version: 1.0 Subject: Re: Review Request 70320: Used `ResourceQuantities` in `__allocate()` when appropriate. From: Mesos Reviewbot To: Benjamin Mahler Cc: Mesos Reviewbot , Meng Zhu , mesos Date: Thu, 28 Mar 2019 03:43:49 -0000 Message-ID: <20190328034349.24116.95364@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70320/ X-Sender: Mesos Reviewbot References: <20190327053113.64515.83999@reviews-vm2.apache.org> In-Reply-To: <20190327053113.64515.83999@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============2697739184919069624== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70320/#review214152 ----------------------------------------------------------- Patch looks great! Reviews applied: [70318, 70319, 70320] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 27, 2019, 5:31 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70320/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 5:31 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9504 > https://issues.apache.org/jira/browse/MESOS-9504 > > > Repository: mesos > > > Description > ------- > > Replaced `Resources` with `ResourceQuantities` when > appropriate in `__allocate()`. This simplifies the > code and improves performance. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp 36bf90baf413e99c1580d516dfac0f074335d322 > src/master/allocator/mesos/hierarchical.cpp 8bc749903b8ceb09a02e260919377483479302b5 > > > Diff: https://reviews.apache.org/r/70320/diff/2/ > > > Testing > ------- > > make check > Benchmark results in r/70330 > > > Thanks, > > Meng Zhu > > --===============2697739184919069624==--