From reviews-return-86653-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 27 16:44:15 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 64E5319635 for ; Wed, 27 Mar 2019 16:44:15 +0000 (UTC) Received: (qmail 34953 invoked by uid 500); 27 Mar 2019 16:44:15 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 34924 invoked by uid 500); 27 Mar 2019 16:44:15 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 34901 invoked by uid 99); 27 Mar 2019 16:44:14 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2019 16:44:14 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2B4CCE07DE; Wed, 27 Mar 2019 16:44:14 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1701CC40B77; Wed, 27 Mar 2019 16:44:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0224050883245530352==" MIME-Version: 1.0 Subject: Re: Review Request 70117: Added unit tests for offer operation feedback metrics. From: Benno Evers To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Joseph Wu , Greg Mann Cc: Mesos Reviewbot , Mesos Reviewbot Windows , Benno Evers , mesos Date: Wed, 27 Mar 2019 16:44:14 -0000 Message-ID: <20190327164414.24117.22306@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70117/ X-Sender: Benno Evers References: <20190315000157.64872.88564@reviews-vm2.apache.org> In-Reply-To: <20190315000157.64872.88564@reviews-vm2.apache.org> Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============0224050883245530352== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On March 15, 2019, 12:01 a.m., Greg Mann wrote: > > Could you also update a test to verify that metrics transition correctly? i.e., that operation metrics will start at `pending == 0` and `finished == 0`, then transition to `pending == 1` and `finished == 0`, then finally to `pending == 0` and `finished == 1`? Would be nice to do this for both the global and per-operation metrics. Good point, I've added this check to `MasterTests.OperationUpdateDuringFailover`. As an interesting aside, this was the *only* test in our whole test suite that I could find where an operation transitions out of the `PENDING` state, maybe that indicates we're missing some test to verify the basic operation lifecycle. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213732 ----------------------------------------------------------- On March 27, 2019, 4:41 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70117/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 4:41 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-8241 > https://issues.apache.org/jira/browse/MESOS-8241 > > > Repository: mesos > > > Description > ------- > > This adds a set of checks to verify the metrics introduced > in the previous commit are working as intended. > > > Diffs > ----- > > src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f > src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2 > src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a > src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9 > src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e > src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 > src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699 > src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58 > src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843 > src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87 > > > Diff: https://reviews.apache.org/r/70117/diff/7/ > > > Testing > ------- > > > Thanks, > > Benno Evers > > --===============0224050883245530352==--