From reviews-return-86650-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Mar 27 16:39:09 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02E2619604 for ; Wed, 27 Mar 2019 16:39:09 +0000 (UTC) Received: (qmail 16115 invoked by uid 500); 27 Mar 2019 16:39:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 16082 invoked by uid 500); 27 Mar 2019 16:39:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 16041 invoked by uid 99); 27 Mar 2019 16:39:08 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2019 16:39:08 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D26B2E07DE; Wed, 27 Mar 2019 16:39:07 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id BE56CC4027D; Wed, 27 Mar 2019 16:39:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6683815959320123311==" MIME-Version: 1.0 Subject: Re: Review Request 70116: Added metrics for offer operation feedback. From: Benno Evers To: =?utf-8?q?Gast=C3=B3n_Kleiman?= , Joseph Wu , Greg Mann Cc: Benno Evers , mesos Date: Wed, 27 Mar 2019 16:39:07 -0000 Message-ID: <20190327163907.24117.72807@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/70116/ X-Sender: Benno Evers References: <20190326175657.64514.3715@reviews-vm2.apache.org> In-Reply-To: <20190326175657.64514.3715@reviews-vm2.apache.org> Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============6683815959320123311== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/ ----------------------------------------------------------- (Updated March 27, 2019, 4:39 p.m.) Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. Changes ------- Clarified comment; clearly distinguished between gauges and counters in documentation. Bugs: MESOS-8241 https://issues.apache.org/jira/browse/MESOS-8241 Repository: mesos Description ------- This commit adds additional metrics counting the number of operations in each state. Unit tests are added in the subsequent commit. Diffs (updated) ----- docs/monitoring.md 54b872f579dbc68ca5f67f4cc1ba34065a09aee2 src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 src/master/metrics.hpp 4495e65b6bb11f7236335a702c4f61e7c3f9b0aa src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9 Diff: https://reviews.apache.org/r/70116/diff/6/ Changes: https://reviews.apache.org/r/70116/diff/5-6/ Testing ------- Thanks, Benno Evers --===============6683815959320123311==--